Image generation: rely on activation_scale_factor for GPU #1548
+33
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-lavrenov
force-pushed
the
activation-scale-factor
branch
2 times, most recently
from
ccf07df to
b3182d0
Compare
ilya-lavrenov
force-pushed
the
activation-scale-factor
branch
from
b3182d0 to
97d36b3
Compare
ilya-lavrenov
commented
Jan 15, 2025
| @@ -137,25 +137,17 @@ class StableDiffusion3Pipeline : public DiffusionPipeline { | |||
|
|
|||
| set_scheduler(Scheduler::from_config(root_dir / "scheduler/scheduler_config.json")); | |||
|
|
|||
| // Temporary fix for GPU | |||
There was a problem hiding this comment.
since this WA is not released yet (added to master after 2024.6), we can safely drop it and rely on official solution
likholat
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for implementation on optimum-intel and GPU sides